Fix #576 for Array when having ports with tuples #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -210,6 +210,10 @@ Elm.Native.Utils.make = function(elm) { | |||
| return Tuple2(posx, posy); | |||
| } | |||
|
|
|||
| function isJSArray(a) { | |||
| return Array.isArray(a); | |||
There was a problem hiding this comment.
It 's in the JS standard library: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray
But I just saw that instanceof should be used, because a could be Null. I'll change this.
There was a problem hiding this comment.
It looks like null instanceof Array is also false. I suspect that using instanceof is faster and it's definitely clearer to me, so I support the change. Should this function ever return true for null though?
xash
changed the title
|
Should be good to go! :-) |
|
Cool, thank you! :D |
evancz
pushed a commit
that referenced
this pull request
Apr 15, 2014
Fix #576 for Array when having ports with tuples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.