-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arrays to pass through ports #597
Comments
If you point me in the right direction I can try to implement this myself. |
This is how it was done for Looking back on that code, it'd be cool if we could make it so |
Okay, thanks. @xashili Why did you take out the |
Here is what I've figured out. If we put back the |
I opened a pull request with the functions, #603. |
#603 is merged. My plan is to have this come with 0.13. I don't want to sit on 0.12.1 any longer! |
If you like, but I think I've almost got it. |
As long as I can publish tomorrow with confidence :) |
Well... that's your call to make. I've tested incoming and outgoing and it seems to work, but I haven't run it through a proper test battery. The port code I just pushed is actually fairly simple. @xashili how much testing did you do for to/from JSArray? |
Answer: enough. Unless something jumps out at you I think we're good to merge. |
Send the PR! |
Oh, you can't merge from issues? Okay. |
The groundwork seems to have been laid in #585, but it doesn't appear to be allowed yet. Also update the error message in
ExtraChecks.hs
.The text was updated successfully, but these errors were encountered: