Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade httparrot to 1.4.0 #687

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Upgrade httparrot to 1.4.0 #687

merged 3 commits into from
Jun 25, 2024

Conversation

nathany-copia
Copy link
Contributor

closes #684

@nathany-copia nathany-copia mentioned this pull request Jun 25, 2024
Closed
yordis
yordis approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to cry right now 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭

@yordis yordis merged commit d39d575 into elixir-tesla:master Jun 25, 2024
5 checks passed
@nathany-copia
Copy link
Contributor Author

tears of joy?

@nathany-copia nathany-copia deleted the parrot branch June 25, 2024 19:04
@yordis
Copy link
Member

yordis commented Jun 25, 2024

tears of joy?

Both, joy and pain!

@nathany-copia
Copy link
Contributor Author

Thanks @yordis.

It's very nice that we can run the test suite with a recent version of Elixir now.
Makes it easier to contribute in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yordis yordis yordis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures and compiler warnings in Elixir 1.16 (httparrot)
2 participants
@nathany-copia @yordis