Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Tesla #38

Closed
yordis opened this issue May 1, 2024 · 8 comments
Closed

Upgrading Tesla #38

yordis opened this issue May 1, 2024 · 8 comments

Comments

@yordis
Copy link

yordis commented May 1, 2024

As requested @edgurgel

I am having some difficulty upgrading Tesla to OTP 26 and the httparrot SSL config, check the CI status: elixir-tesla/tesla#623

I also tried to use OTP 25+ built-in public key certs stuff, but it didn't work, I am pretty sure something in the configuration is broken that I am failing to see.

I would appreciate some help with it.

@edgurgel
Copy link
Owner

edgurgel commented Jun 3, 2024

Thanks, @yordis! Yeah we definitely need to update httparrot to run on newer Erlang and Elixir versions. Might need to review the SSL setup 🤔

@yordis
Copy link
Author

yordis commented Jun 18, 2024

It seems to be an SSL problem for sure, maybe the built-in certs needs to be updated or much better, using the OTP 25+ built-in functions to get the certs

@nathany-copia
Copy link
Contributor

nathany-copia commented Jun 19, 2024

@edgurgel Any plans to update httparrot for Elixir 1.16?

I'm not sure how helpful I can be with certificate issues. 🤔

Also related, would you like the Travis CI config updated for newer versions of Elixir or switched to GitHub Actions?

@edgurgel
Copy link
Owner

edgurgel commented Jun 21, 2024

I'm going to sort out this SSL issue this weekend! The help with the GitHub Actions will be great thank you

@nathany-copia
Copy link
Contributor

Thanks @edgurgel.

@nathany-copia
Copy link
Contributor

This issue can be closed.

elixir-tesla/tesla#687 upgrades Tesla to httparrot 1.4, and all tests pass in Elixir 1.16.

Thanks again @edgurgel.

@yordis
Copy link
Author

yordis commented Jun 25, 2024

@edgurgel, for my sanity's sake, ideally, we should document how to generate those SSLs somewhere, at the very least some Make command, even though we may not have the private key.

Regardless, thank you so much for the help! I gain a few white hairs over SSL (classic)

@yordis yordis closed this as completed Jun 25, 2024
@edgurgel
Copy link
Owner

Oh I just used https://github.com/FiloSottile/mkcert ! I intend to later on make it so that it can generate on boot so it never expires as mkcert's certificates expire after 2 years I think? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants