Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: revise helloworld example #244

Merged
merged 1 commit into from
Jul 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions examples/helloworld/lib/helloworld.pb.ex
Original file line number Diff line number Diff line change
@@ -1,31 +1,25 @@
defmodule Helloworld.HelloRequest do
use Protobuf
@moduledoc false
use Protobuf, protoc_gen_elixir_version: "0.10.0", syntax: :proto3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add this manually or did protoc generate this via the protobuf plugin? I don't think it's cool that we have to change these files after they've been created if that's the case here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sleipnir i generate it with protoc. This change added since plugin version 0.10


@type t :: %__MODULE__{
name: String.t()
}
defstruct [:name]

field :name, 1, optional: true, type: :string
field :name, 1, type: :string
end

defmodule Helloworld.HelloReply do
use Protobuf

@type t :: %__MODULE__{
message: String.t()
}
defstruct [:message]
@moduledoc false
use Protobuf, protoc_gen_elixir_version: "0.10.0", syntax: :proto3

field :message, 1, optional: true, type: :string
field :message, 1, type: :string
end

defmodule Helloworld.Greeter.Service do
use GRPC.Service, name: "helloworld.Greeter"
@moduledoc false
use GRPC.Service, name: "helloworld.Greeter", protoc_gen_elixir_version: "0.10.0"

rpc :SayHello, Helloworld.HelloRequest, Helloworld.HelloReply
end

defmodule Helloworld.Greeter.Stub do
@moduledoc false
use GRPC.Stub, service: Helloworld.Greeter.Service
end
4 changes: 1 addition & 3 deletions examples/helloworld/lib/helloworld_app.ex
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ defmodule HelloworldApp do
use Application

def start(_type, _args) do
import Supervisor.Spec

children = [
supervisor(GRPC.Server.Supervisor, [{Helloworld.Endpoint, 50051}])
{GRPC.Server.Supervisor, {Helloworld.Endpoint, 50051}}
]

opts = [strategy: :one_for_one, name: HelloworldApp]
Expand Down