refactor: revise helloworld example #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revise children in HelloworldApp to use a new way of declaring supervisor. * Generate proto code with elixir-protobuf 0.10.
wingyplus
force-pushed
the
overhaul-example
branch
from
3b585ae
to
52fbe89
Compare
polvalente
approved these changes
Jul 22, 2022
sleipnir
reviewed
Jul 22, 2022
| @@ -1,31 +1,25 @@ | |||
| defmodule Helloworld.HelloRequest do | |||
| use Protobuf | |||
| @moduledoc false | |||
| use Protobuf, protoc_gen_elixir_version: "0.10.0", syntax: :proto3 | |||
There was a problem hiding this comment.
Did you add this manually or did protoc generate this via the protobuf plugin? I don't think it's cool that we have to change these files after they've been created if that's the case here
There was a problem hiding this comment.
@sleipnir i generate it with protoc. This change added since plugin version 0.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declaring supervisor.
proto folder.