Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block emails user unsubscribed from #218

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Block emails user unsubscribed from #218

merged 7 commits into from
Aug 22, 2024

Conversation

elie222
Copy link
Owner

@elie222 elie222 commented Aug 22, 2024

  • Blocks emails that user has unsubscribed from. Even if the sender keeps sending emails. It labels these as "Unsubscribed".
  • Allows cancelling an unsubscribe.
  • Adds local search for bulk unsub page.

Summary by CodeRabbit

  • New Features

    • Introduced a new SearchBar component for filtering newsletters.
    • Added functionality to block emails from users who have unsubscribed from newsletters.
    • Enhanced the bulk unsubscribe feature with event tracking and improved usability.
  • Improvements

    • Renamed props for clarity across several components.
    • Streamlined internal logic and improved the unsubscribe link handling.
    • Simplified function signatures for better readability.
  • Bug Fixes

    • Enhanced error handling in the email blocking feature.
  • Style Changes

    • Updated button appearances across multiple components for a more cohesive design.

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero 🔄 Building (Inspect) Visit Preview Aug 22, 2024 10:19am

@elie222 elie222 merged commit c0a41f2 into main Aug 22, 2024
1 of 2 checks passed
@elie222 elie222 deleted the block-unsubbed-emails branch August 22, 2024 10:19
Copy link
Contributor

coderabbitai bot commented Aug 22, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve renaming props for clarity, specifically updating setOpenedNewsletter to onOpenNewsletter across multiple components. This refactor enhances the semantic meaning of the props. Additionally, new components like SearchBar are introduced, and existing components have their internal logic modified for improved functionality. Enhancements in user interaction tracking and label management are also included.

Changes

Files Change Summary
apps/web/app/(app)/bulk-unsubscribe/BulkUnsubscribeDesktop.tsx, BulkUnsubscribeMobile.tsx, BulkUnsubscribeSection.tsx, common.tsx, types.ts Renamed setOpenedNewsletter to onOpenNewsletter, modified internal logic, and added a SearchBar for filtering.
apps/web/app/(app)/new-senders/NewSenders.tsx Simplified function signatures and replaced setOpenedNewsletter with onOpenNewsletter.
apps/web/app/(app)/bulk-unsubscribe/ShortcutTooltip.tsx, DetailedStatsFilter.tsx Changed button styles by updating the variant prop from "link" to "ghost" and "outline" to "ghost".
apps/web/app/api/ai/cold-email/controller.ts Renamed gmailLabel to coldEmailLabel, improved error handling for label absence.
apps/web/app/api/google/webhook/block-unsubscribed-emails.ts Introduced blockUnsubscribedEmails function for handling unsubscribed user emails.
apps/web/app/utils/label.ts Added "Unsubscribed" to inboxZeroLabels.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BulkUnsubscribeSection
    participant SearchBar
    participant BulkUnsubscribeRowDesktop
    participant BulkUnsubscribeRowMobile

    User->>BulkUnsubscribeSection: Interacts with unsubscribe feature
    BulkUnsubscribeSection->>SearchBar: Initiate search
    SearchBar-->>BulkUnsubscribeSection: Return search results
    BulkUnsubscribeSection->>BulkUnsubscribeRowDesktop: Update rows based on search
    BulkUnsubscribeSection->>BulkUnsubscribeRowMobile: Update rows based on search
Loading

🐰 In a world of clicks and tabs,
New names hop in like happy jabs.
Unsubscribed? No need to fret,
With new tools, the best is set!
Search and track with joyful cheer,
🥕 Changes bring us all good cheer!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant