Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(did): simulation modifications #240

Merged
merged 2 commits into from
Sep 13, 2022
Merged

fix(did): simulation modifications #240

merged 2 commits into from
Sep 13, 2022

Conversation

dixitaniket
Copy link
Contributor

@dixitaniket dixitaniket commented Sep 5, 2022 •
edited by PaddyMc
Loading

Description

Updating simulations to reflect the changes to inhibit vanity DIDs #220

How to test

  • make test-sim-benchmark

Output

 "did": {
  "/elestodao.elesto.did.v1.MsgAddController": {
   "failure": 2086,
   "ok": 1191
  },
  "/elestodao.elesto.did.v1.MsgAddService": {
   "failure": 2143,
   "ok": 1118
  },
  "/elestodao.elesto.did.v1.MsgAddVerification": {
   "failure": 2158,
   "ok": 1239
  },
  "/elestodao.elesto.did.v1.MsgCreateDidDocument": {
   "failure": 1235,
   "ok": 2089
  },
  "/elestodao.elesto.did.v1.MsgDeleteController": {
   "failure": 2013,
   "ok": 1178
  },
  "/elestodao.elesto.did.v1.MsgDeleteService": {
   "failure": 2754,
   "ok": 594
  },
  "/elestodao.elesto.did.v1.MsgRevokeVerification": {
   "failure": 2642,
   "ok": 600
  },
  "/elestodao.elesto.did.v1.MsgSetVerificationRelationships": {
   "failure": 5459,
   "ok": 1181
  },
  "/elestodao.elesto.did.v1.MsgUpdateDidDocument": {
   "failure": 2122,
   "ok": 1258
  }
 },

@dixitaniket dixitaniket linked an issue Sep 6, 2022 that may be closed by this pull request
Review the simulations for the DID module #234
Closed
@dixitaniket dixitaniket marked this pull request as ready for review September 6, 2022 15:39
@dixitaniket dixitaniket requested a review from a team as a code owner September 6, 2022 15:39
@dixitaniket dixitaniket requested review from Bartkeeper and removed request for a team September 6, 2022 15:39
@PaddyMc
Copy link
Contributor

PaddyMc commented Sep 12, 2022 •
edited
Loading

I updated the description! Great work here @dixitaniket

🙇

PaddyMc
PaddyMc approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@dixitaniket dixitaniket merged commit 5c0f8f3 into main Sep 13, 2022
@PaddyMc PaddyMc deleted the fix/did-simulations branch September 14, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaddyMc PaddyMc PaddyMc approved these changes

@Bartkeeper Bartkeeper Bartkeeper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review the simulations for the DID module
3 participants
@dixitaniket @PaddyMc @Bartkeeper