Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(did): inhibiting the creation vanity DIDs #220

Merged
merged 7 commits into from
Sep 1, 2022
Merged

Conversation

Bartkeeper
Copy link
Contributor

This PR should inhibit Vanity DIDs by creating a UUID as the didId when creating the document. CLI_test.go still needs to be updated

@noandrea noandrea added the BREAKING:CONSENSUS Refers to a consensus breaking change label Aug 29, 2022
@Bartkeeper Bartkeeper marked this pull request as ready for review August 29, 2022 21:23
@Bartkeeper Bartkeeper requested a review from a team as a code owner August 29, 2022 21:23
@PaddyMc
Copy link
Contributor

PaddyMc commented Aug 30, 2022

Ace! Works well! GGWP

I created a PR into this branch to update the identifier seeds => #227

✔️

@PaddyMc PaddyMc changed the title Inhibit vanity DIDs feat(did): inhibiting the creation vanity DIDs Aug 31, 2022
@PaddyMc PaddyMc merged commit a91b1fc into main Sep 1, 2022
@barriebyron barriebyron deleted the inhibit-vanity-dids branch September 2, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING:CONSENSUS Refers to a consensus breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants