Port to Gtk4 #53
Port to Gtk4 #53
Conversation
|
@Marukesu how to test the Access portal? portal-test does not seem to support it atm: flatpak/libportal#95 |
|
@marbetschar you could crash Mail 😂 or its also used for the confirmation dialog when you change display settings |
|
@marbetschar you can use the background portal, or the location portal. Alternatively, you can use d-spy/d-feet to call the access portal directly, this way you don't mess with permissions, but it's not as easy to test window parenting this way. |
|
From a functionality point of view this PR works. However, the AccessDialog is unusually large (in its height). Does anyone have an idea why? I don't seem to be able to figure out the root cause of this (tested in a eOSv7 VirtualBox VM):
|
|
@danrabbit any idea why we the AccessDialog's height is so large? Apart from that this PR is ready and will serve as ground work for me to (finally) start working on #19 |
|
@marbetschar definitely a bug in Granite. Looking into that now... |
Co-authored-by: Gustavo Marques <[email protected]>
Fixes #45
Fixes #52
Closes #60
Todos:
Turned out there is no set_keep_above anymore in Gtk4 and we don't know the window_parent in the non-working scenarios (maybe because of the Flatpak app calling the portal too early). That said, we can't do much here from a portals point of view. Therefore "Done" as we assume its the app's responsibility to call the portal at the correct point in time.