Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageDialog: Fix large height bug #616

Merged
merged 3 commits into from
Jun 17, 2022
Merged

MessageDialog: Fix large height bug #616

merged 3 commits into from
Jun 17, 2022

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 16, 2022 •
edited
Loading

Fix code style while we're here

BEFORE

Screenshot from 2022-06-16 11 15 33

AFTER

Screenshot from 2022-06-16 11 13 18

@danirabbit danirabbit requested a review from a team June 16, 2022 18:31
@danirabbit danirabbit mentioned this pull request Jun 16, 2022
Merged
4 tasks
marbetschar
marbetschar approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@marbetschar marbetschar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue - and improved the code. Nice, thank you!

@marbetschar marbetschar merged commit 28e9b60 into main Jun 17, 2022
@marbetschar marbetschar deleted the messagedialog-heightfix branch June 17, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marbetschar marbetschar marbetschar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @marbetschar