Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version constraint to allow the latest poetry-core 1.9.1 #17902

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Update version constraint to allow the latest poetry-core 1.9.1 #17902

merged 2 commits into from
Nov 6, 2024

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Nov 4, 2024 •
edited
Loading

Update version constraint to allow the latest poetry-core 1.9.1

Context:

I am working on updating poetry-core in Fedora and synapse is one of affected packages. Please run a CI to see if it works properly. Thank you.

Mergeable version of #17848 (original contributor @hrnciar)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods mentioned this pull request Nov 4, 2024
Closed
3 tasks
@MadLittleMods MadLittleMods marked this pull request as ready for review November 5, 2024 21:23
@MadLittleMods MadLittleMods requested a review from a team as a code owner November 5, 2024 21:23
anoadragon453
anoadragon453 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI indeed passes!

@MadLittleMods MadLittleMods merged commit e1f5da6 into develop Nov 6, 2024
39 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/mergable-pr-17848 branch November 6, 2024 16:51
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @anoadragon453 🐜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @anoadragon453