Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version constraint to allow the latest poetry-core 1.9.1 #17848

Closed
wants to merge 1 commit into from

Conversation

hrnciar
Copy link

@hrnciar hrnciar commented Oct 18, 2024

Hello, I am working on updating poetry-core in Fedora and synapse is one of affected packages. Please run a CI to see if it works properly. Thank you.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@hrnciar hrnciar requested a review from a team as a code owner October 18, 2024 07:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hrnciar
Copy link
Author

hrnciar commented Nov 1, 2024

My manager couldn't confirm whether I am allowed to sign the CLA. I've contacted our legal team, but I haven't gotten any response yet. Consider this as a public domain and feel free to commit the change under your name.

@MadLittleMods
Copy link
Contributor

Consider this as a public domain and feel free to commit the change under your name.

I've created #17902 to avoid merging some commits from someone who hasn't signed the CLA ⏩

MadLittleMods added a commit that referenced this pull request Nov 6, 2024
…17902)

Update version constraint to allow the latest `poetry-core` `1.9.1`

Context:

> I am working on updating poetry-core in Fedora and synapse is one of
affected packages. Please run a CI to see if it works properly. Thank
you.

Mergeable version of #17848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants