-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update subscriptions if visible range rooms change without the range itself changing #3220
Conversation
…hen then update to come into the visible range.
…out the range itself changing - we switched from range based subscribing with duplicate suppression to id based, but ids can change without ranges changing - the all rooms list fetches at least 1 event per rooms and can cause rooms to come in and out of the visible range without user interaction
Generated by 🚫 Danger Swift against f42b9fc |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3220 +/- ##
===========================================
- Coverage 77.59% 77.38% -0.21%
===========================================
Files 723 723
Lines 57282 57414 +132
===========================================
- Hits 44446 44431 -15
- Misses 12836 12983 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only say it looks sane 😅
RoomSummaryProvider