Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscriptions if visible range rooms change without the range itself changing #3220

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

stefanceriu
Copy link
Member

  • we switched from range based subscribing with duplicate suppression to id based, but ids can change without ranges changing
  • the all rooms list fetches at least 1 event per rooms and can cause rooms to come in and out of the visible range without user interaction
  • this PR rewrites how we handle visible ranges and moves processing of both the range (for pagination) and the room identifiers (for subscriptions) within the RoomSummaryProvider

…hen then update to come into the visible range.
…out the range itself changing

- we switched from range based subscribing with duplicate suppression to id based, but ids can change without ranges changing
- the all rooms list fetches at least 1 event per rooms and can cause rooms to come in and out of the visible range without user interaction
@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 2, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 2, 2024 14:00
Copy link

github-actions bot commented Sep 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f42b9fc

Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 7.93651% with 58 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (302df18) to head (f42b9fc).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 58 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3220      +/-   ##
===========================================
- Coverage    77.59%   77.38%   -0.21%     
===========================================
  Files          723      723              
  Lines        57282    57414     +132     
===========================================
- Hits         44446    44431      -15     
- Misses       12836    12983     +147     
Flag Coverage Δ
unittests 68.16% <7.93%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only say it looks sane 😅

@stefanceriu stefanceriu merged commit 288b1e7 into develop Sep 2, 2024
12 checks passed
@stefanceriu stefanceriu deleted the stefan/3088 branch September 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants