Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SS room subscriptions even if the visible range doesn't change #3379

Closed
stefanceriu opened this issue Sep 2, 2024 · 1 comment
Closed

Update SS room subscriptions even if the visible range doesn't change #3379

stefanceriu opened this issue Sep 2, 2024 · 1 comment
Labels
A-Room List A-SSS Regression or bug observed when using Simplified Sliding Sync O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@stefanceriu
Copy link
Member

  • we switched from range based subscribing with duplicate suppression to id based, but ids can change without ranges changing
  • the all rooms list fetches at least 1 event per rooms and can cause rooms to come in and out of the visible range without user interaction

Related to element-hq/element-x-ios#3088
Fixed on iOS in element-hq/element-x-ios#3220
@stefanceriu stefanceriu added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Room List A-SSS Regression or bug observed when using Simplified Sliding Sync labels Sep 2, 2024
@stefanceriu stefanceriu changed the title Update SS room subscriptions even if the visible range doesn't update Update SS room subscriptions even if the visible range doesn't change Sep 2, 2024
@jmartinesp
Copy link
Member

I think there's nothing to do on Android for this one, when an item changes the visible range is updated and the new room ids are subscribed to, from what I saw in a quick test.

@jmartinesp jmartinesp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room List A-SSS Regression or bug observed when using Simplified Sliding Sync O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmartinesp @stefanceriu