-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI iteration on the encryption settings #3750
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3750 +/- ##
===========================================
- Coverage 83.05% 82.98% -0.07%
===========================================
Files 1754 1749 -5
Lines 43994 43973 -21
Branches 5142 5154 +12
===========================================
- Hits 36539 36492 -47
- Misses 5632 5656 +24
- Partials 1823 1825 +2 ☔ View full report in Codecov by Sentry. |
Change wording of setup recovery key banner and change target to root. Iterate on wording of encryption screen. Change button to Switch. Iterate on wording to delete key storage. Iterate on wording and icon on the root setting. Remove confirmation dialog when disabling backup. Add subtitle to change recovery key action. Enable key storage directly, remove quite empty screen to setup the backup. Disable recovery action if key backup is disabled.
589af73
to
1e0c212
Compare
I mentioned 2 issues on #2590:
|
Quality Gate passedIssues Measures |
Discussion was in #2590, so I think there is no blockers from @americanrefugee anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Content
Iterate on crypto screen, UX flow and wording, so that it matches what has been designed at https://www.figma.com/design/qTWRfItpO3RdCjnTKPu4mL/Settings?node-id=1651-24968&node-type=canvas&m=dev
Motivation and context
Closes #3737
Closes #3738
Closes #3739
Screenshots / GIFs
CryptoIteration.mp4
Tests
Tested devices
Checklist