Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update room member list contents after changing member roles #2590

Closed
VolkerJunginger opened this issue Mar 22, 2024 · 2 comments · Fixed by #2591
Closed

Update room member list contents after changing member roles #2590

VolkerJunginger opened this issue Mar 22, 2024 · 2 comments · Fixed by #2591
Assignees
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@VolkerJunginger
Copy link

Steps to reproduce

Userflow:

  • Invite a new user to a room
  • The user does not accept the invite
  • Go to moderation make that pending user an admin
  • Go to the member list

Android does not show that the pending member is an admin - iOS does.

To Do

Show user-role for pending members.

Side-note
Yes, it makes sense to be able to change the role of a future member. This way I can invite someone and then already give them the right role and don't have to come back later.

Screenshot

Outcome

What did you expect?

What happened instead?

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

@VolkerJunginger VolkerJunginger added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 22, 2024
@ganfra
Copy link
Member

ganfra commented Mar 22, 2024

@jmartinesp do u take the point ?

@jmartinesp
Copy link
Member

Yup, already checking it. If I'm not mistaken the problem isn't that we don't display roles for pending users, it's that the list isn't updated: if I get out of the room screen and enter it again the members are reloaded and they display the right roles.

It's a side effect of #2564 being too restrictive.

@jmartinesp jmartinesp self-assigned this Mar 22, 2024
@jmartinesp jmartinesp changed the title Ad user role to pending member Update room member list contents after changing member roles Mar 22, 2024
@manuroe manuroe removed their assignment Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants