Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update member list after changing member roles #2591

Merged

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Mar 22, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Update member list after changing member roles.
  • Also do it when the user enters the room member list screen in case some change came from another client.
  • Have RoomMemberListDataSource retrieve only active users (joined + invited).

Motivation and context

Fixes #2590.

Tests

  • In a room where you're an admin, go to it's settings -> roles and permissions.
  • Change the role of some other user to moderator (ideally a user with a pending invite if you want to make sure the reported scenario is fixed).
  • Go to the room member list. Check it's a moderator now.
  • Go back to the roles and permissions screen, demote it to user again.
  • Back again to the room member list, check it's a non-privileged user again.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner March 22, 2024 09:19
@jmartinesp jmartinesp requested review from ganfra and removed request for a team March 22, 2024 09:19
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MSSMWs

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.20%. Comparing base (f4e5934) to head (5030257).
Report is 18 commits behind head on develop.

Files Patch % Lines
...nt/android/libraries/matrix/api/room/RoomMember.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2591   +/-   ##
========================================
  Coverage    73.20%   73.20%           
========================================
  Files         1413     1413           
  Lines        34296    34301    +5     
  Branches      6670     6672    +2     
========================================
+ Hits         25105    25109    +4     
- Misses        5717     5718    +1     
  Partials      3474     3474           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 25, 2024
@ganfra ganfra enabled auto-merge March 25, 2024 09:43
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 25, 2024
@bmarty
Copy link
Member

bmarty commented Mar 26, 2024

ANR on Maestro, let's run again.

image

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 26, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 26, 2024
@ganfra ganfra merged commit 865b8b0 into develop Mar 26, 2024
21 of 22 checks passed
@ganfra ganfra deleted the fix/jme/2590-update-room-member-list-after-changing-roles branch March 26, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update room member list contents after changing member roles
3 participants