Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-sdk version to rust-sdk 0.2.57 #3735

Merged
merged 10 commits into from
Oct 24, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Oct 24, 2024

Content

Base PR to update all breaking changes with the new rust-sdk version. Do not merge yet.
Here is the stak of PR to be merged on this one:

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr added the PR-Change For updates to an existing feature label Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/SjQYnG

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 24, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Oct 24, 2024
LocalEventSendState.Failed.SendingFromUnverifiedDevice
}
is QueueWedgeError.IdentityViolations -> {
// smart cast impossible because 'error' is a public API property declared in different module
Copy link
Member

@bmarty bmarty Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the screenshot will be recorded, I'll push a commit to fix this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (f44c8dd) to head (4ef231c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...line/components/event/TimelineItemEncryptedView.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3735   +/-   ##
========================================
  Coverage    83.05%   83.05%           
========================================
  Files         1754     1754           
  Lines        43980    43994   +14     
  Branches      5142     5142           
========================================
+ Hits         36526    36540   +14     
+ Misses        5633     5632    -1     
- Partials      1821     1822    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 24, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 24, 2024
@BillCarsonFr BillCarsonFr marked this pull request as ready for review October 24, 2024 14:14
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 24, 2024 14:14
@BillCarsonFr BillCarsonFr requested review from ganfra and removed request for a team October 24, 2024 14:14
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/bump_rust_sdk_0.2.57 branch from adf4442 to 4ef231c Compare October 24, 2024 14:17
Copy link

sonarcloud bot commented Oct 24, 2024

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 24, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 24, 2024
@jmartinesp
Copy link
Member

Ah, my bad, I re-ran Maestro when it had already succeeded before.

@jmartinesp jmartinesp merged commit 9fb68fc into develop Oct 24, 2024
29 checks passed
@jmartinesp jmartinesp deleted the feature/valere/bump_rust_sdk_0.2.57 branch October 24, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants