Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trust & Decoration | Support new expected UTD causes #3729

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Trust & Decoration | Support new expected UTD causes #3729

merged 1 commit into from
Oct 24, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Oct 23, 2024 •
edited
Loading

Fixes #3624
Fixes #3626
Fixes #3628

Depends on rust-sdk PR matrix-org/matrix-rust-sdk#4126

Content

When Exclude Insecure devices mode is enabled there are new unable to decrypt errors:
image

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr force-pushed the feature/valere/support_new_utd_causes branch from f207dd3 to f0bf69e Compare October 23, 2024 15:52
@ElementBot
Copy link
Collaborator

ElementBot commented Oct 23, 2024 •
edited
Loading

Fails
🚫

Please add a PR- label to categorise the changelog entry.
Messages
📖 Sign-off not required, allow-list

Generated by 🚫 dangerJS against c82357c

@BillCarsonFr BillCarsonFr force-pushed the feature/valere/support_new_utd_causes branch from f0bf69e to c82357c Compare October 24, 2024 08:56
@BillCarsonFr BillCarsonFr changed the base branch from develop to feature/valere/update_send_queue_changes October 24, 2024 08:56
@BillCarsonFr BillCarsonFr mentioned this pull request Oct 24, 2024
Merged
10 tasks
@BillCarsonFr BillCarsonFr marked this pull request as ready for review October 24, 2024 09:55
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 24, 2024 09:55
@BillCarsonFr BillCarsonFr requested review from bmarty and removed request for a team October 24, 2024 09:55
jmartinesp
jmartinesp approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feature/valere/update_send_queue_changes to feature/valere/bump_rust_sdk_0.2.57 October 24, 2024 12:25
@BillCarsonFr BillCarsonFr merged commit f30a860 into feature/valere/bump_rust_sdk_0.2.57 Oct 24, 2024
11 of 23 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/support_new_utd_causes branch October 24, 2024 12:26
@BillCarsonFr BillCarsonFr mentioned this pull request Oct 25, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

@bmarty bmarty Awaiting requested review from bmarty bmarty was automatically assigned from element-hq/element-x-android-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@BillCarsonFr @ElementBot @jmartinesp