Fix 'remove alias' button in room settings #28269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
|
this is my first open source contribution please tell me what am i doing wrong? |
florianduros
requested changes
Oct 23, 2024
|
I have made the change, and this should fix that. Is it possible to check by myself if all the errors are solved? |
|
Click on View deployment of the e2e test line: or The check mark is green in the CI check |
|
is it working now? |
florianduros
changed the title
florianduros
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Closes #27985
Before and After Comparison:
Explanation:
The size of the button had to be increased to prevent the "close room settings" button from breaking. The images above show the difference before and after the changes, with the button's size adjustment ensuring proper functionality and alignment.