Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually broken 'remove alias' button #27985

Closed
dbkr opened this issue Sep 2, 2024 · 6 comments · Fixed by #28269
Closed

Visually broken 'remove alias' button #27985

dbkr opened this issue Sep 2, 2024 · 6 comments · Fixed by #28269
Labels
A-Room-Settings good first issue Good for newcomers Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Sep 2, 2024

Steps to reproduce

  1. Find a room where you have admin
  2. Open settings
  3. Add a local alias if it doesn't already have one
  4. See:
Screenshot 2024-09-02 at 10 11 19

Outcome

What did you expect?

Something that looks like a delete button

What happened instead?

An 'x' and a separate tiny red blob

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@dbkr dbkr added the T-Defect label Sep 2, 2024
@dosubot dosubot bot added A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Sep 2, 2024
@dbkr dbkr added A-Room-Settings O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience good first issue Good for newcomers and removed A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 2, 2024
@github-actions github-actions bot added the Help Wanted Extra attention is needed label Sep 2, 2024
@jenish064
Copy link

Hi @dbkr, I would like to work on this issue but new to matrix.org. Can you please elaborate on how do I find room with an admin (mentioned in step 1).

@dbkr
Copy link
Member Author

dbkr commented Sep 6, 2024

If you create a room, you'll have admin in it.

@Dev-Gurjar
Copy link
Contributor

241019_05h25m47s_screenshot

I fixed it. What should I do now? Should I send the pull request?

@Dev-Gurjar
Copy link
Contributor

the size of the button has to be big otherwise the button for closing room settings will get broken.

trying to attach the changes - d0faf72

@florianduros
Copy link
Member

@Dev-Gurjar Yes, you should open a pull request. More information in the contributing guide.

@florianduros
Copy link
Member

Fixed in #27985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Settings good first issue Good for newcomers Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants