Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace remaining "Use Key Backup" strings with "Connect ..." instead #9542

Closed
jryans opened this issue Apr 23, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#2931
Closed

Replace remaining "Use Key Backup" strings with "Connect ..." instead #9542

jryans opened this issue Apr 23, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#2931
Assignees
@jryans
Labels
A-E2EE A-E2EE-Key-Backup Help Wanted Extra attention is needed T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 23, 2019

In matrix-org/matrix-react-sdk#2917, we changed one "Use Key Backup" string (in the backup details panel of settings) to instead say "Connect this device to Key Backup".

There are other usages "Use ..." in the room reminder and logout, so we should also change these to "Connect ...".
@jryans jryans mentioned this issue Apr 23, 2019
Merged
5 tasks
@jryans jryans self-assigned this Apr 24, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Apr 24, 2019
@jryans
Also say "Connect ..." on remaining key backup buttons
4784d5e 
This updates the remaining buttons shown when a backup exists but is not trusted
so that they all now say "Connect this device to Key Backup" instead of "Use Key
Backup".

This is a follow up to matrix-org#2917
and was agreed with Riot iOS team
element-hq/element-ios#2375 (comment).

Fixes element-hq/element-web#9542
@jryans jryans mentioned this issue Apr 24, 2019
Merged
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE A-E2EE-Key-Backup Help Wanted Extra attention is needed T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also say "Connect ..." on remaining key backup buttons jryans/matrix-react-sdk
1 participant
@jryans