Clarify key backup details when backup exists but is not trusted #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports the wording changes from Riot Web matrix-org/matrix-react-sdk#2917. "Use key backup" as button text feels like it's telling me I haven't set it up at all. This changes to "Connect this device ..." which seems more reassuring and applies for both the "add to backup" and "restore from backup" use cases. This also updates the backup status text for the case where a backup exists, but it's not being used by the current device so that it's much more clear that you have a backup at least.
|
Thanks @jryans for pointing out this change. With this PR, we still display it like this: Would it be cleared like that (if yes, don't do it, I can push my commit on this PR): |
|
@manuroe At the moment, we have not changed the in-room recovery reminder for Riot Web, so it still says "Use Key Backup" similar to your iOS example, but thanks for mentioning this! I think it improves readability and understanding to replace all the "Use ..." strings with "Connect ...", so I recommend adding your suggested commit here. I filed element-hq/element-web#9542 for Riot Web to also update these remaining strings to say "Connect ...". |
|
Great. I merge your PR and great another one on top of it |
manuroe
added a commit
that referenced
this pull request
Apr 24, 2019
…anner too This follows changes made by #2375
jryans
added a commit
to jryans/matrix-react-sdk
that referenced
this pull request
Apr 24, 2019
This updates the remaining buttons shown when a backup exists but is not trusted so that they all now say "Connect this device to Key Backup" instead of "Use Key Backup". This is a follow up to matrix-org#2917 and was agreed with Riot iOS team element-hq/element-ios#2375 (comment). Fixes element-hq/element-web#9542
This was referenced Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the wording changes from Riot Web
matrix-org/matrix-react-sdk#2917.
"Use key backup" as button text feels like it's telling me I haven't set it up
at all. This changes to "Connect this device ..." which seems more reassuring
and applies for both the "add to backup" and "restore from backup" use cases.
This also updates the backup status text for the case where a backup exists, but
it's not being used by the current device so that it's much more clear that you
have a backup at least.
Pull Request Checklist