"User changed their display name" when both display name and avatar URL was updated

[anoadragon453]

Description

Element will render displayname and avatar changes in a room timeline. Typically Matrix clients will change either a user's display or avatar URL, but it is certainly possible to do both at the same time.

Element looks to only report that the displayname has changed in this case:

These events come from the same user. Notice that they have two different avatars, even though an avatar change was never mentioned. This user is a puppeted Discord user. Presumably Discord will only emit one event for changing both your avatar and display name.

Here is the source of the first member event:

{
  "type": "m.room.member",
  "sender": "@XXX:amorgan.xyz",
  "content": {
    "membership": "join",
    "displayname": "salka",
    "avatar_url": "mxc://amorgan.xyz/327a39df4a30a4a9e7598a9e470ae67627ca0a3a"
  },
  "state_key": "@XXX:amorgan.xyz",
  "origin_server_ts": 1626442795112,
  "unsigned": {
    "replaces_state": "$Cwc3fEtk9cch0nXCa6VC5q5Z9JXe8By9Ncx7QbtR6CE",
    "prev_content": {
      "membership": "join",
      "displayname": "and the rainfall",
      "avatar_url": "mxc://amorgan.xyz/7a45cc450cbdee29db2b01e5b2e351ba9eb95ac5"
    },
    "prev_sender": "@XXX:amorgan.xyz",
    "age": 8366039
  },
  "event_id": "$q8dUWvPktZTm0zi0FTDZlUFAMRO0eBEDHZK6Wgbu1z4",
  "room_id": "!YYY:amorgan.xyz"
}

and the second:

{
  "type": "m.room.member",
  "sender": "@XXX:amorgan.xyz",
  "content": {
    "membership": "join",
    "displayname": "and the rainfall",
    "avatar_url": "mxc://amorgan.xyz/327a39df4a30a4a9e7598a9e470ae67627ca0a3a"
  },
  "state_key": "@XXX:amorgan.xyz",
  "origin_server_ts": 1626442795243,
  "unsigned": {
    "replaces_state": "$q8dUWvPktZTm0zi0FTDZlUFAMRO0eBEDHZK6Wgbu1z4",
    "prev_content": {
      "membership": "join",
      "displayname": "salka",
      "avatar_url": "mxc://amorgan.xyz/327a39df4a30a4a9e7598a9e470ae67627ca0a3a"
    },
    "prev_sender": "@XXX:amorgan.xyz",
    "age": 8365908
  },
  "event_id": "$gj4DYKyAhc4v10AgNWl0B98HRLkneN7Y9LfUSgjypgM",
  "room_id": "!YYY:amorgan.xyz"
}

Steps to reproduce

• Modify your displayname and avatar URL in a new m.room.member event with join membership sent to the room.
• Notice that the rendered timeline event only mentions the display name change.

Logs being sent: no

Following what Element Android does, we could say "User changed their display name from X to Y (avatar was changed too)".

I also noticed Element Android will say "You changed your display name ..." if you were the sender, which is a nice touch :)

Version information

• Platform: desktop
• OS: Linux
• Version: Nightly 2021071601

[t3chguy]

Element clearly cannot fathom the things it cannot do :P

[t3chguy]

Hmm, so doing this whilst maintaining the good i18n will be kind of a pain as it'll involve adding many more strings due to the number of existing permutations here