Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VerificationRequestDialog suitable for self-verification #12725

Open
4 of 5 tasks
bwindels opened this issue Mar 13, 2020 · 5 comments
Open
4 of 5 tasks

Make VerificationRequestDialog suitable for self-verification #12725

bwindels opened this issue Mar 13, 2020 · 5 comments
Assignees
@bwindels
Labels
A-E2EE-Cross-Signing

Comments

@bwindels
Copy link
Contributor

bwindels commented Mar 13, 2020 •
edited by t3chguy
Loading

  • keep showing SetupEncryptionDialog with spinner while accepting request on new session, rather than VerificationRequestDialog.
  • implement design once ready
  • adapt e2e tests
  • remove IncomingSasDialog (should be unused now apart from in MatrixChat because of above reason)
  • remove DeviceVerifyDialog
@bwindels bwindels mentioned this issue Mar 13, 2020
Closed
@bwindels
Copy link
Contributor Author

This should also say something like "Session verified" rather than the same UX/copy for verifying another user:
image

@bwindels
Copy link
Contributor Author

#12682 is related

@bwindels bwindels changed the title Stop using IncomingSasDialog Make VerificationRequestDialog suitable for self-verification Mar 13, 2020
@bwindels bwindels mentioned this issue Mar 23, 2020
Closed
@bwindels
Copy link
Contributor Author

Video of process here: https://matrix.to/#/!maVEfftuKxhnPMcckU:matrix.org/$1584350035621770EiNmc:matrix.org?via=matrix.org&via=vector.modular.im&via=riot.ovh but already somewhat outdated because of SetupEncryptionDialog (see todo list at top)

@jryans jryans mentioned this issue Mar 31, 2020
Closed
@jryans jryans mentioned this issue Apr 2, 2020
Closed
@bwindels bwindels mentioned this issue Apr 2, 2020
Merged
@bwindels
Copy link
Contributor Author

bwindels commented Apr 2, 2020

Notes what to fix: https://docs.google.com/document/d/1JxxjthxipQ0XUn8mIHY-UMKniwVaayyqX8ZoT5flSdQ/edit

Figma for modal qr reciprocate: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=4089%3A19

@bwindels bwindels self-assigned this Apr 2, 2020
@bwindels bwindels mentioned this issue Apr 3, 2020
Merged
@bwindels bwindels removed the phase:3 label Apr 3, 2020
@jryans jryans added the phase:4 label Apr 6, 2020
@kittykat
Copy link
Contributor

Message that confirms self-verification is still wrong and talking about „this user“.

t3chguy added a commit that referenced this issue Oct 17, 2024
@t3chguy @richvdh
Improve new room header accessibility (#12725)
466f37a 
* Fix room header topic not showing on keyboard navigation whilst still using tabstops

Signed-off-by: Michael Telatynski <[email protected]>

* Fix keyboard activation of the room header FacePile

Signed-off-by: Michael Telatynski <[email protected]>

* Fix label on room header facepile

Signed-off-by: Michael Telatynski <[email protected]>

* Comment

Signed-off-by: Michael Telatynski <[email protected]>

* Update src/components/views/elements/FacePile.tsx

Co-authored-by: Richard van der Hoff <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @bwindels @jryans @duxovni