Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button overlaps dialog text on incoming verification #12717

Closed
ara4n opened this issue Mar 12, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4659
Closed

Close button overlaps dialog text on incoming verification #12717

ara4n opened this issue Mar 12, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4659

Comments

@ara4n
Copy link
Member

ara4n commented Mar 12, 2020

(I'm slightly surprised to see this coming in as a dialog rather than a toast or in the timeline?)

Screenshot 2020-03-12 at 21 15 26

@ara4n ara4n added the T-Defect label Mar 12, 2020
@bwindels
Copy link
Contributor

bwindels commented Mar 13, 2020

I assume this is with somebody who doesn't have cross-signing enabled? We're showing to_devicerequests in a dialog because we don't have a room to show a right panel in. We're still using the old IncomingSasDialog because the new VerificationRequestDialog still breaks the e2e tests and has some UX pitfalls, tracked as #12725

@jryans
Copy link
Collaborator

jryans commented May 20, 2020

It would be good to work out how we're even reaching this old modal. I haven't seen it myself recently, but there are several link issues above from seemingly both self-verif and other user verif.

@t3chguy
Copy link
Member

t3chguy commented May 28, 2020

This modal is used for to_device SAS verification, such as that incoming from a non-cross-signing device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants