Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end-to-end encryption information dialog shows 'NOT verified' when device was cross-signed #12556

Closed
uhoreg opened this issue Feb 27, 2020 · 1 comment

Comments

@uhoreg
Copy link
Member

uhoreg commented Feb 27, 2020

It's probably still checking device verification rather than cross-signed verification. ref: https://matrix.to/#/!gGkYcJLTzcNrfERksd:matrix.org/$Zd2y9UxgQ1mvt6XXOtlSD0EkKa2r-8ncSvENBqGqFWQ?via=matrix.org&via=privacytools.io&via=feneas.org

@jryans
Copy link
Collaborator

jryans commented Feb 27, 2020

Yes, it has not been updated. There's some desire to just remove it entirely, but decision taken yet.

Let's use #11752 for this.

@jryans jryans closed this as completed Feb 27, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
Which should be 1024 according to the designs, not 768
JohnSimonsen pushed a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
* Upgrade dependency to [email protected]

* v3.100.0-rc.0

* Upgrade dependency to [email protected]

* Remove code smell assertion identified by Sonar (element-hq#12547)

* This assertion is unnecessary since the receiver accepts the original type of the expression

* Implement `client.getDomain()` null check

* Update comment since `AutoDiscovery.findClientConfig` may still throw

* Report verification and recovery state to posthog (element-hq#12516)

* Report verification and recovery state to posthog

* Fix CryptoApi import

* Fix js-sdk import

* Review: Use DeviceVerificationStatus instead of CrossSigningStatus

* Review: Clean condition to check secrets in 4S

* review: Fix redundent !!

* Deprecate `Tooltip.tsx`

* Use tooltip compound in `MessageComposer.tsx`

* Use tooltip compound in `ReadReceiptGroup` component

* Use tooltip compound in `ReadReceiptPerson` component

* Delete `useTooltip.tsx`

* Use compound tooltip in `ReactionRowButton`

* Upgrade dependency to [email protected]

* Migrate `TooltipTarget` usage to compound `Tooltip` (element-hq#12542)

* Use new tooltip in `RoomTopic.tsx`

* Use new tooltip in `MLocationBody.tsx`

* Fix room topic

* Update location snapshot

* Use new tooltip in `AppPermission.tsx`

* Remove `TooltipTarget`

* Add tests for `RoomTopic`

* Add tests for `ReadReceiptGroup.tsx`

* Add more tests for `ReadReceiptGroup.tsx`

* Add more test for `ReactionsRowButton.tsx`

* Add seedrandom dep to `resolutions` (element-hq#12552)

* Move seedrandom dep to `resolutions`

... to shut renovate up

* Reinstate `seedrandom` as dev dependency

If we just declare it in `resolutions`, it doesn't get installed at all,
because it is only a devDependency of `bloom-filters`.

* [create-pull-request] automated change (element-hq#12554)

Co-authored-by: github-merge-queue <[email protected]>

* Avoid using deprecated exports, fields, and duplicate code (element-hq#12555)

* Fix tabbedview breakpoint width (element-hq#12556)

Which should be 1024 according to the designs, not 768

* Tooltip: close field tooltip when ESC is pressed (element-hq#12553)

* Close field tooltip when ESC is pressed

* Use `Key.ESCAPE`

* Close the release announcement when a dialog is opened (element-hq#12559)

* Fire `ModalManagerEvent.Closed` when a dialog is closed

* Listen to modal events in the RA

* Fix first RA test

* Upgrade dependency to [email protected]

* v3.100.0-rc.1

* Upgrade dependency to [email protected]

* v3.100.0

---------

Co-authored-by: RiotRobot <[email protected]>
Co-authored-by: Ed Geraghty <[email protected]>
Co-authored-by: Valere <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants