Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or kill EncryptedEventDialog #11752

Closed
dbkr opened this issue Jan 2, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4644
Closed

Update or kill EncryptedEventDialog #11752

dbkr opened this issue Jan 2, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4644
Assignees

Comments

@dbkr
Copy link
Member

dbkr commented Jan 2, 2020

Needs to be updated to reflect cross-signing verification status, but personally I would really like to kill it off. The info it presents is all available elsewhere and it's mostly misleading (sending device is never displayed for UTD messages and everybody assumes that it's UTD because the sender is unknown rather than the other way around).

@jryans jryans added story:34 and removed epic:2 labels Jan 16, 2020
@jryans jryans added phase:4 and removed story:34 labels Feb 11, 2020
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 15, 2020
This end-to-end info dialog repeats info available elsewhere and has not been
updated to make sense for cross-signing, triggers old verification methods, etc.
For now, this hides the option to present a more consistent UI.

Relates to element-hq/element-web#11752
@jryans
Copy link
Collaborator

jryans commented Apr 15, 2020

matrix-org/matrix-react-sdk#4412 starts us down the path by at least hiding the option to access this when cross-signing is enabled.

@jryans
Copy link
Collaborator

jryans commented May 15, 2020

Product is okay with removing this.

@dbkr dbkr self-assigned this May 26, 2020
@dbkr
Copy link
Member Author

dbkr commented May 26, 2020

Apparently we already disabled it anyway when cross-signing is active: matrix-org/matrix-react-sdk#4412

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue May 26, 2020
#4412 disabled it
when cross signing was enabled so it is essentially gone now anyway.

Fixes element-hq/element-web#11752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants