Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opening/closing the right panel resets scroll position in the timeline #12414

Closed
richvdh opened this issue Feb 19, 2020 · 1 comment
Closed

opening/closing the right panel resets scroll position in the timeline #12414

richvdh opened this issue Feb 19, 2020 · 1 comment

Comments

@richvdh
Copy link
Member

richvdh commented Feb 19, 2020

... which is abit annoying
@t3chguy
Copy link
Member

t3chguy commented Feb 19, 2020

Duplicate of #9822

@t3chguy t3chguy marked this as a duplicate of #9822 Feb 19, 2020
@t3chguy t3chguy closed this as completed Feb 19, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@turt2live @richvdh
Extract functions for service worker usage, and add initial MSC3916 p…
d25d529 
…laywright test (when supported) (#12414)

* Send user credentials to service worker for MSC3916 authentication

* appease linter

* Add initial test

The test fails, seemingly because the service worker isn't being installed or because the network mock can't reach that far.

* Remove unsafe access token code

* Split out base IDB operations to avoid importing `document` in serviceworkers

* Use safe crypto access for service workers

* Fix tests/unsafe access

* Remove backwards compatibility layer & appease linter

* Add docs

* Fix tests

* Appease the linter

* Iterate tests

* Factor out pickle key handling for service workers

* Enable everything we can about service workers

* Appease the linter

* Add docs

* Rename win32 image to linux in hopes of it just working

* Use actual image

* Apply suggestions from code review

Co-authored-by: Richard van der Hoff <[email protected]>

* Improve documentation

* Document `??` not working

* Try to appease the tests

* Add some notes

---------

Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @t3chguy