Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing the right sidebar scrolls to the bottom in a room #9822

Closed
anoadragon453 opened this issue May 23, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4197
Closed
Assignees
Labels
A-Right-Panel A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Mozilla

Comments

@anoadragon453
Copy link
Member

Description

Just spent a long time today scrolling up in the room looking for an old image that was sent. Thought I might be able to find it quicker if I opened the right sidebar to look at the file viewer. Unfortunately, when you do so it resets the scroll in the room as if you've clicked to another room and then back again.

My naive guess is that it's recreating the message list widget or something, but I'm not actually sure how the UI of Riot works here. I assume it's not necessary and we only need to resize it like we do when we collapse the left room list.

Example video: https://streamable.com/bdrbb

Version information

  • Platform: web
  • Browser: Firefox v69
  • OS: Debian Stretch
  • URL: riot.im/develop
@jryans jryans added defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 A-Right-Panel A-Timeline labels May 24, 2019
@jryans
Copy link
Collaborator

jryans commented May 24, 2019

Yes, I have also noticed that toggling the notifications panel causes the timeline to remount as well, so seemingly anything in the right panel triggers this.

Seems good to investigate and fix for both app efficiency and better UX.

@hramrach
Copy link

hramrach commented Nov 1, 2019

Seems the behavior has changed. Showing the side pane does not scroll to the bottom anymore but to some random point in the channel (maybe the message that was shown when you opened the channel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Right-Panel A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Mozilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants