Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negotiate E2E by default for DMs #12005

Closed
jryans opened this issue Jan 22, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3913
Closed

Negotiate E2E by default for DMs #12005

jryans opened this issue Jan 22, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3913
Assignees
@jryans
Labels
A-E2EE-Cross-Signing

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 22, 2020

When the cross-signing labs flag is on, we want to create DMs as E2E by default. There are no UX changes or toggles in the create DM flow for this. Since not all users support E2E yet (bots, bridges, people with only non-E2E clients), we need to be a bit careful.

When creating the DM room, check if the other user has shared device keys. If yes, then create an encrypted room, otherwise fallback to unencrypted.
@jryans jryans self-assigned this Jan 23, 2020
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 23, 2020
@jryans
Enable encryption in DMs with device keys
1e25b32 
When the cross-signing lab is enabled, this changes DMs to use encryption as
long as all invited users have uploaded device keys (which we're using as a
proxy for "has some client that understands E2E").

Fixes element-hq/element-web#12005
@jryans jryans mentioned this issue Jan 23, 2020
Merged
@manuroe manuroe mentioned this issue Jan 27, 2020
Closed
@manuroe
Copy link
Member

manuroe commented Jan 27, 2020

Kamino cloned this issue to vector-im/riot-ios

@manuroe manuroe mentioned this issue Jan 27, 2020
Closed
@manuroe
Copy link
Member

manuroe commented Jan 27, 2020

Kamino cloned this issue to vector-im/riotX-android

@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable encryption in DMs with device keys matrix-org/matrix-react-sdk
2 participants
@jryans @manuroe