Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negotiate E2E by default for DMs #2943

Closed
manuroe opened this issue Jan 27, 2020 · 1 comment · Fixed by #2946
Closed

Negotiate E2E by default for DMs #2943

manuroe opened this issue Jan 27, 2020 · 1 comment · Fixed by #2946
Assignees
@manuroe
Labels
A-E2EE feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint 25: Cross-...

Comments

@manuroe
Copy link
Member

manuroe commented Jan 27, 2020

From riot-web created by jryans: element-hq/element-web#12005

When the cross-signing labs flag is on, we want to create DMs as E2E by default. There are no UX changes or toggles in the create DM flow for this. Since not all users support E2E yet (bots, bridges, people with only non-E2E clients), we need to be a bit careful.

When creating the DM room, check if the other user has shared device keys. If yes, then create an encrypted room, otherwise fallback to unencrypted.
@manuroe manuroe mentioned this issue Jan 27, 2020
Closed
@manuroe manuroe mentioned this issue Jan 27, 2020
Open
@manuroe manuroe self-assigned this Jan 27, 2020
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 28, 2020
@manuroe
MXRoomCreationParameters: Support the initial_state parameter and all…
877afe8 
…ow e2e on room creation

element-hq/element-ios/issues/2943
@manuroe manuroe mentioned this issue Jan 28, 2020
Merged
manuroe added a commit that referenced this issue Jan 28, 2020
@manuroe
Negotiate E2E by default for DMs
c032c08 
#2943
@manuroe manuroe mentioned this issue Jan 28, 2020
Merged
manuroe added a commit that referenced this issue Jan 28, 2020
@manuroe
Negotiate E2E by default for DMs
12ec147 
#2943
@manuroe
Copy link
Member Author

manuroe commented Jan 28, 2020

Kamino cloned this issue to vector-im/riotX-android

@jryans jryans added the phase:1 label Feb 12, 2020
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-E2EE feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint 25: Cross-signing and e2e by d...
Development

Successfully merging a pull request may close this issue.

Negotiate E2E by default for DMs element-hq/element-ios
3 participants
@kittykat @jryans @manuroe