vector-im/element-ios/issues/4976 - Replaced GrowingTextView with sim… #5052
Conversation
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HFtfJn |
Riot/Modules/Room/Views/InputToolbar/RoomInputToolbarTextView.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Room/Views/InputToolbar/RoomInputToolbarTextView.swift
Outdated
Show resolved
Hide resolved
|
|
||
| NotificationCenter.default.addObserver(self, selector: #selector(textDidChange), name: UITextView.textDidChangeNotification, object: self) | ||
|
|
||
| if let heightConstraint = constraints.filter({ $0.firstAttribute == .height && $0.relation == .equal }).first { |
There was a problem hiding this comment.
Would this potentially break if someone added an equal heights constraint between the text view and something else in the future?
There was a problem hiding this comment.
Break might a a strong word. If there's another height constraint set and the textView detects it then it will set its height on that.
If there's 2 of them active at the same time for some reason you will either see breaking constraints or it will just work if the priorities are different.
Either way, it breaking shouldn't be a particularly hard problem to find or fix.
…tation. Cleaned up the RoomInputToolbar header.
stefanceriu
force-pushed
the
stefan/4976-input-toolbar-text-view
branch
from
318a46e
to
efa726b
Compare
|
A couple of things I've noticed in use:
|
…r resize animations.
…pler, custom implementation. Cleaned up the RoomInputToolbar header.