Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HPGrowingTextView with a newer component #4976

Closed
stefanceriu opened this issue Oct 11, 2021 · 0 comments
Closed

Replace HPGrowingTextView with a newer component #4976

stefanceriu opened this issue Oct 11, 2021 · 0 comments
Assignees
@stefanceriu

Comments

@stefanceriu
Copy link
Member

HPGrowingTextView is somewhat out of date and triggers a lot of warnings in the project, reason we have inhibit warnings from it in our pod file. It also doesn't inherit from UITextView making some other changes we have in mind somewhat more difficult.
The best replacement seems to be GrowingTextView and we should go for it.
@stefanceriu stefanceriu self-assigned this Oct 11, 2021
stefanceriu added a commit that referenced this issue Oct 11, 2021
@stefanceriu
Fixes #4976 - Replaced HPGrowingTextView with GrowingTextView. Reduce…
5d81c42 
…d inheritance chain.
stefanceriu added a commit that referenced this issue Oct 12, 2021
@stefanceriu
Fixes #4976 - Replaced HPGrowingTextView with GrowingTextView. Reduce…
825dae9 
…d inheritance chain.
stefanceriu added a commit that referenced this issue Oct 26, 2021
@stefanceriu
/issues/4976 - Replaced GrowingTextView with simpler, custom implemen…
318a46e 
…tation. Cleaned up the RoomInputToolbar header.
stefanceriu added a commit that referenced this issue Oct 26, 2021
@stefanceriu
/issues/4976 - Replaced GrowingTextView with simpler, custom implemen…
efa726b 
…tation. Cleaned up the RoomInputToolbar header.
stefanceriu added a commit that referenced this issue Oct 27, 2021
@stefanceriu
/issues/4976 - Fixed placeholder not displaying after being hidden fo…
7e6e82d 
…r resize animations.
stefanceriu added a commit that referenced this issue Oct 27, 2021
@stefanceriu
Merge pull request #5052 from vector-im/stefan/4976-input-toolbar-tex…
04aaec2 
…t-view

/issues/4976 - Replaced GrowingTextView with sim…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanceriu