Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contacts section from people tab #4608

Merged
merged 11 commits into from
Jul 28, 2021

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 26, 2021

Fixes #4523.

• Local contacts are no longer shown.
• Headers are now hidden (height set to 0).

Frame 1

@pixlwave pixlwave marked this pull request as ready for review July 27, 2021 15:29
@niquewoodhouse
Copy link

@nadonomy I just want to explain this papercut as it may come up as a controversial change for some experienced users (esp those with lots of invites). It is intended to merge this ahead of the next RC. There is already a merged issue that does a similar thing to the Rooms tab (removes the headings, removes the room directory)

From the people's tab it removes:

  • If you have any invites to DM, the invites header & the conversations header (reasons here)
  • The immediate access to local contacts (reasons here)

@pixlwave pixlwave merged commit 2af67b9 into develop Jul 28, 2021
@pixlwave pixlwave deleted the doug/4523_remove_contacts_from_people_tab branch July 28, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to predictably tap “Local contacts” on People tab
3 participants