Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to predictably tap “Local contacts” on People tab #4523

Closed
pixlwave opened this issue Jul 2, 2021 · 6 comments · Fixed by #4608
Closed

Hard to predictably tap “Local contacts” on People tab #4523

pixlwave opened this issue Jul 2, 2021 · 6 comments · Fixed by #4608
Assignees
Labels
X-Needs-Design May require input from the design team Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1

Comments

@pixlwave
Copy link
Member

pixlwave commented Jul 2, 2021

Similar to #4521 tapping the section name can result in tapping the "Matrix users only" checkbox.

Removal of section might help.
The header for the Conversations section could then go too, however when there is an invite a second section will be added.

From: @niquewoodhouse

@pixlwave pixlwave added X-Needs-Design May require input from the design team Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1 Z-Impact-1 labels Jul 2, 2021
@pixlwave pixlwave added this to the iOS platform papercuts milestone Jul 5, 2021
@pixlwave pixlwave self-assigned this Jul 7, 2021
@pixlwave
Copy link
Member Author

pixlwave commented Jul 7, 2021

A screenshot of the People tab as it currently exists with an invite, conversations and contacts:

Simulator Screen Shot - iPhone 12 mini - 2021-07-07 at 16 46 44

@niquewoodhouse
Copy link

@pixlwave thank you. So I think we're best to not have an invites header, if thats happening also on the Rooms tab.

Just noticed the invite for people says has "user invited you". Maybe neither of us knows but would be good if someone could confirm if other people can invite you to chat with a third person? Otherwise, it's maybe redundant info and needs a redesign.

Removing the contacts section makes a lot of sense to me (third image)

  • It's alphabetical, so the top results might mean very little to me (I get alot of about@ email addresses from companies).
  • It's unlike other similar messaging apps (Signal exposes people you know who are on Signal which might be a good thing to consider if we have contacts access but that's probably out of scope)

One thing we lose by removing the contacts section is a state for when we don't have contacts access, to encourage it.

image

@pixlwave
Copy link
Member Author

pixlwave commented Jul 7, 2021

So I think we're best to not have an invites header, if thats happening also on the Rooms tab.

👍

Just noticed the invite for people says has "user invited you". Maybe neither of us knows but would be good if someone could confirm if other people can invite you to chat with a third person? Otherwise, it's maybe redundant info and needs a redesign.

Just checked and inviting a third user into an existing conversation actually sends the invite through as a room invite. Not sure if that's technically a bug, I will look into this tomorrow.

(Signal exposes people you know who are on Signal which might be a good thing to consider if we have contacts access but that's probably out of scope)

Would this essentially be ticking the "Matrix users only" checkbox by default, and then hiding the header?

One thing we lose by removing the contacts section is a state for when we don't have contacts access, to encourage it.

There is still the prompt when starting a new conversation:
Screenshot 2021-07-07 at 17 49 45

@pixlwave
Copy link
Member Author

pixlwave commented Jul 8, 2021

inviting a third user into an existing conversation actually sends the invite through as a room invite. Not sure if that's technically a bug, I will look into this tomorrow.

This behaviour matches Android too. It seems the spec only has the functionality to invite someone into a direct conversation when creating the room and not after the fact.

@niquewoodhouse
Copy link

Would this essentially be ticking the "Matrix users only" checkbox by default, and then hiding the header?

It would be pretty much that but I think that's a bigger change that would need more consideration from a product pov

@pixlwave
Copy link
Member Author

pixlwave commented Jul 8, 2021

Got it. So as part of this, remove the section with a view of a filtered section possibly coming back in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Design May require input from the design team Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants