Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: prettier blog sidebar styles #623

Merged
merged 3 commits into from
Aug 13, 2024
Merged

style: prettier blog sidebar styles #623

merged 3 commits into from
Aug 13, 2024

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Aug 13, 2024

Minimal lines of code to achieve the same effect I think?

Ref #622 (comment)

Upside: no swizzling
Downside: these attribute selectors are brittle and Docusaurus considers them to be internal implementation details: https://docusaurus.io/docs/styling-layout#theme-class-names

@erickzhao erickzhao requested a review from a team as a code owner August 13, 2024 01:05
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-623 August 13, 2024 01:06 Inactive
@erickzhao erickzhao force-pushed the prettier-blog-sidebar branch from 20104c2 to 6c0d732 Compare August 13, 2024 01:07
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-623 August 13, 2024 01:07 Inactive
@erickzhao erickzhao force-pushed the prettier-blog-sidebar branch from 6c0d732 to e287e5b Compare August 13, 2024 01:10
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-623 August 13, 2024 01:10 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-623 August 13, 2024 01:34 Inactive
src/css/custom.scss Outdated Show resolved Hide resolved
Co-authored-by: David Sanders <[email protected]>
@erickzhao erickzhao requested a review from dsanders11 August 13, 2024 17:14
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-623 August 13, 2024 17:14 Inactive
@dsanders11 dsanders11 merged commit 0ddc7c8 into main Aug 13, 2024
3 checks passed
@dsanders11 dsanders11 deleted the prettier-blog-sidebar branch August 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants