build: docusaurus 3.5 upgrade #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicelovescake
approved these changes
Aug 12, 2024
|
This got merged as I was writing this up. 😅 Looks like there's a few visual changes to the blog as a result of this PR. Not to bikeshed too much, but I kind prefer some parts of the blog sidebar as they currently are, like the border below the title. I wonder if we can retain any of those styles without needing to swizzle the whole component? The blog author name not being centered vertically looks to be intentional but IMO is awkward looking. Looks like if we used the new authors pages features and put author's GitHub as a social it might render better. Before: 
After: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Docusaurus 3.5.
patch-packagesince we don't need patches anymore.mdast-util-mdxto the dependency tree so that we can pass it in as an extension totoMarkdown(). We do some hacky Markdown -> MDAST -> Markdown conversion in the API structure preview transformer that now has an MDX node by default as of feat(mdx-loader): wrap mdx content title (# Title) in<header>for concistency facebook/docusaurus#10335 so this is needed to render those previews now.