feat(publisher-gcs): add Google Cloud Storage publisher #2100

mahnunchik · 2020-12-18T13:51:29Z

Continue of #1752

codecov · 2020-12-18T15:51:49Z

Codecov Report

Merging #2100 (593f2c3) into master (7050550) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          74       74           
  Lines        2221     2221           
  Branches      420      420           
=======================================
  Hits         1615     1615           
  Misses        446      446           
  Partials      160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7050550...593f2c3. Read the comment docs.

mahnunchik · 2020-12-21T12:38:36Z

Hi @malept could you please review this PR.

mahnunchik · 2021-02-03T13:01:12Z

@malept 😢

mahnunchik · 2021-06-21T12:44:26Z

Hi @malept when my PR may be accepted?

packages/publisher/gcs/src/PublisherGCS.ts

patgpt

A review was required.

mahnunchik · 2022-11-09T08:43:20Z

@erickzhao What about Google Cloud Storage publisher? I really need it for my workflow

.github/CODEOWNERS

packages/publisher/gcs/package.json

packages/publisher/gcs/src/PublisherGCS.ts

mahnunchik · 2022-11-11T15:37:18Z

@MarshallOfSound @erickzhao @BlackHole1 I've decided to rebase on top of current main and squash to single commit.

mahnunchik · 2022-11-14T12:03:20Z

Should I rebase PR again?

packages/publisher/gcs/src/PublisherGCS.ts

erickzhao · 2022-12-22T21:57:48Z

packages/publisher/gcs/src/Config.ts

+  keyFilename?: string;
+  /**
+   * The Google Cloud project ID.
+   *
+   * Defaults to the value in the `GOOGLE_CLOUD_PROJECT` environment variable.
+   * */
+  projectId?: string;
+  /**
+   * The email for your Google service account, *required* when using a PEM/PKCS #12-formatted
+   * file in the [[keyFilename]] option.
+   *
+   * Defaults to the value in the `GOOGLE_CLOUD_CLIENT_EMAIL` environment variable.
+   */
+  clientEmail?: string;
+  /**
+   * The private key for your Google service account.
+   *
+   * Defaults to the value in the `GOOGLE_CLOUD_PRIVATE_KEY` environment variable.
+   */
+  privateKey?: string;


comment: For these auth-related options, can we put them in a separate auth object?

I think the previous comment in this chain is still a valid concern. It might be cleaner to put all auth-related private key config options under an auth property.

packages/publisher/gcs/src/Config.ts

mahnunchik · 2023-01-16T18:44:15Z

@erickzhao I was able to rebase PR on top of current main by fighting the dependency hell... I make GCS publisher looks like S3 publisher and ported changes from it.

Could you please help me to ship GCS publisher before main have many new changes?

nikashitsa · 2023-01-18T15:42:15Z

Useful feature for me also.

mahnunchik · 2023-09-13T20:25:38Z

@erickzhao could I ask for a review of this PR?

mahnunchik · 2023-09-19T02:24:19Z

@erickzhao I've rebase PR on top of current changes. Could you please tell me what should I do to have this PR merged?

mahnunchik · 2023-09-20T17:29:56Z

I'm using this publisher for a years, published by my package name. Could we make this PR merged?

mahnunchik · 2023-10-09T16:17:08Z

@MarshallOfSound @erickzhao I need this publisher in the application. What can I do to get the PR accepted?

mahnunchik · 2023-10-17T17:22:27Z

@MarshallOfSound @erikian @erickzhao ping

BlackHole1 · 2023-10-18T01:42:24Z

Hi @mahnunchik . I saw @erickzhao commented on some issues. If they have been resolved, you can click the “Resolve conversation” button. If you have any questions regarding the issues, you can comment below. This will help other maintainers with the code review.

mahnunchik · 2023-10-18T16:38:48Z

@BlackHole1 @erickzhao All open conversations was commented by me. GCS publisher is based on S3 publisher, I think both should be close as possible.

erickzhao

Left two minor comments. Also, our policy is generally to only let maintainers commit lockfile changes. Can you also revert yarn.lock here @mahnunchik?

packages/publisher/gcs/package.json

erickzhao · 2023-10-20T23:50:24Z

packages/publisher/gcs/src/Config.ts

+  keyFilename?: string;
+  /**
+   * The Google Cloud project ID.
+   *
+   * Defaults to the value in the `GOOGLE_CLOUD_PROJECT` environment variable.
+   * */
+  projectId?: string;
+  /**
+   * The email for your Google service account, *required* when using a PEM/PKCS #12-formatted
+   * file in the [[keyFilename]] option.
+   *
+   * Defaults to the value in the `GOOGLE_CLOUD_CLIENT_EMAIL` environment variable.
+   */
+  clientEmail?: string;
+  /**
+   * The private key for your Google service account.
+   *
+   * Defaults to the value in the `GOOGLE_CLOUD_PRIVATE_KEY` environment variable.
+   */
+  privateKey?: string;


I think the previous comment in this chain is still a valid concern. It might be cleaner to put all auth-related private key config options under an auth property.

erickzhao · 2023-11-03T21:40:59Z

Here are the tweaks I propose: all the auth-related Storage constructor options should be nested in their own property:

mahnunchik#364

This way we aren't limiting ourselves to a subset of the credential options available via the @google-cloud/storage module, and it's less confusing to have all these options available at the top-level publisher config.

Gcs auth fixes

mahnunchik · 2023-11-03T23:26:16Z

@erickzhao Thank you for your help! Implementation has become much simpler and clearer.

Should I close conversations above? I think everything is fixed now.

This should be a transient dep via `@google-cloud/storage`

erickzhao · 2023-11-04T00:07:55Z

I think everything is fixed! We're planning on releasing a new Forge version within the next week, so hopefully this can make its way in.

erickzhao · 2023-11-16T22:48:33Z

Rebased after the 7.0.0 breaking change release. Once CI is green, going to merge this and get it into a 7.1.0 release before the end of the month.

mahnunchik mentioned this pull request Dec 18, 2020

feat(publisher-gcs): implemented Google Cloud Storage publisher #1752

Closed

5 tasks

mahnunchik force-pushed the gcs branch from 6970611 to 57206f2 Compare December 18, 2020 15:52

mahnunchik mentioned this pull request Dec 21, 2020

docs: add Google Cloud Storage publisher docs electron-forge/electron-forge-docs#9

Merged

devsibwarra reviewed Jul 15, 2021

View reviewed changes

packages/publisher/gcs/src/PublisherGCS.ts Outdated Show resolved Hide resolved

patgpt approved these changes Aug 11, 2022

View reviewed changes

erickzhao self-requested a review August 11, 2022 19:29

MarshallOfSound reviewed Nov 9, 2022

View reviewed changes

mahnunchik force-pushed the gcs branch from 593f2c3 to 61fc0b9 Compare November 11, 2022 15:09

erickzhao mentioned this pull request Nov 23, 2022

build: use a single top-level tsc -b for all packages #3090

Merged

erickzhao changed the title ~~feat(publisher-gcs): implemented Google Cloud Storage publisher~~ feat(publisher-gcs): add Google Cloud Storage publisher Dec 21, 2022

erickzhao requested changes Dec 22, 2022

View reviewed changes

mahnunchik force-pushed the gcs branch from b8972cf to cc587de Compare January 16, 2023 18:39

This was referenced Sep 13, 2023

Add Google Cloud Storage publisher #1751

Open

chore(cli): limit yarn@^1.0.0 #3357

Merged

mahnunchik force-pushed the gcs branch from cc587de to 56dc54f Compare September 19, 2023 02:22

mahnunchik requested a review from a team as a code owner September 19, 2023 02:22

feat(publisher-gcs): implemented Google Cloud Storage publisher

0c91a83

fix(publisher-gcs): ported changes from publisher-s3

e56b9f0

mahnunchik force-pushed the gcs branch from 56dc54f to e56b9f0 Compare September 22, 2023 17:59

erikian requested a review from a team October 18, 2023 00:03

erickzhao self-requested a review October 20, 2023 20:47

erickzhao reviewed Oct 20, 2023

View reviewed changes

erickzhao self-requested a review November 1, 2023 21:53

erickzhao self-assigned this Nov 1, 2023

erickzhao added 3 commits November 2, 2023 17:03

chore: delete yarn.lock changes

83b7aa1

chore: apply lockfile changes

a5f5f00

chore: simplify Config

f760761

Merge pull request #364 from electron/gcs-auth-fixes

f9bee7e

Gcs auth fixes

build(deps): remove google-auth-library dep

e6a212a

This should be a transient dep via `@google-cloud/storage`

erickzhao approved these changes Nov 3, 2023

View reviewed changes

erickzhao added 2 commits November 16, 2023 14:46

Merge branch 'main' into gcs

9fdef7f

Update package.json

f27b8a4

erickzhao merged commit 601314e into electron:main Nov 16, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(publisher-gcs): add Google Cloud Storage publisher #2100

feat(publisher-gcs): add Google Cloud Storage publisher #2100

mahnunchik commented Dec 18, 2020

codecov bot commented Dec 18, 2020 •

edited

Loading

mahnunchik commented Dec 21, 2020

mahnunchik commented Feb 3, 2021

mahnunchik commented Jun 21, 2021

patgpt left a comment

mahnunchik commented Nov 9, 2022

mahnunchik commented Nov 11, 2022

mahnunchik commented Nov 14, 2022

erickzhao Dec 22, 2022

erickzhao Oct 20, 2023 •

edited

Loading

mahnunchik commented Jan 16, 2023

nikashitsa commented Jan 18, 2023

mahnunchik commented Sep 13, 2023

mahnunchik commented Sep 19, 2023

mahnunchik commented Sep 20, 2023

mahnunchik commented Oct 9, 2023

mahnunchik commented Oct 17, 2023

BlackHole1 commented Oct 18, 2023 •

edited

Loading

mahnunchik commented Oct 18, 2023

erickzhao left a comment •

edited

Loading

erickzhao Oct 20, 2023 •

edited

Loading

erickzhao commented Nov 3, 2023

mahnunchik commented Nov 3, 2023

erickzhao commented Nov 4, 2023

erickzhao commented Nov 16, 2023

feat(publisher-gcs): add Google Cloud Storage publisher #2100

feat(publisher-gcs): add Google Cloud Storage publisher #2100

Conversation

mahnunchik commented Dec 18, 2020

codecov bot commented Dec 18, 2020 • edited Loading

Codecov Report

mahnunchik commented Dec 21, 2020

mahnunchik commented Feb 3, 2021

mahnunchik commented Jun 21, 2021

patgpt left a comment

Choose a reason for hiding this comment

mahnunchik commented Nov 9, 2022

mahnunchik commented Nov 11, 2022

mahnunchik commented Nov 14, 2022

erickzhao Dec 22, 2022

Choose a reason for hiding this comment

erickzhao Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

mahnunchik commented Jan 16, 2023

nikashitsa commented Jan 18, 2023

mahnunchik commented Sep 13, 2023

mahnunchik commented Sep 19, 2023

mahnunchik commented Sep 20, 2023

mahnunchik commented Oct 9, 2023

mahnunchik commented Oct 17, 2023

BlackHole1 commented Oct 18, 2023 • edited Loading

mahnunchik commented Oct 18, 2023

erickzhao left a comment • edited Loading

Choose a reason for hiding this comment

erickzhao Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

erickzhao commented Nov 3, 2023

mahnunchik commented Nov 3, 2023

erickzhao commented Nov 4, 2023

erickzhao commented Nov 16, 2023

codecov bot commented Dec 18, 2020 •

edited

Loading

erickzhao Oct 20, 2023 •

edited

Loading

BlackHole1 commented Oct 18, 2023 •

edited

Loading

erickzhao left a comment •

edited

Loading

erickzhao Oct 20, 2023 •

edited

Loading