-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publisher-gcs): implemented Google Cloud Storage publisher #1752
Conversation
Are you volunteering to maintain this publisher? There are already a lot of publisher modules in this monorepo without a maintainer and I'd like to avoid more. Alternatively, you can also maintain this in a separate repository. |
@malept yep, why not. It is pretty simple and I'm interested in this publisher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added you as a code owner of this module via GitHub's CODEOWNERS feature. You'll get pull request notifications any time files in the publisher module get changed.
Can you please add a pull request in https://github.com/MarshallOfSound/electron-forge-docs (which powers electronforge.io
) for this module?
Code fixed, documentation added ✅ |
This is blocked until I get access to merge PRs in the docs repo. |
Ok, got it. @MarshallOfSound could you please look into electron-forge/electron-forge-docs#9 |
@malept Hi, I think electron-forge/electron-forge-docs#9 can be merged. |
@malept What should I do to have this PR merged? |
Implemented Google Cloud Storage publisher (GCS)
ISSUES CLOSED: #1751
Summarize your changes:
Implemented Google Cloud Storage publisher based on official library https://github.com/googleapis/nodejs-storage