Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher-gcs): implemented Google Cloud Storage publisher #1752

Closed
wants to merge 0 commits into from

Conversation

mahnunchik
Copy link
Contributor

@mahnunchik mahnunchik commented Jun 9, 2020

Implemented Google Cloud Storage publisher (GCS)

ISSUES CLOSED: #1751

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Implemented Google Cloud Storage publisher based on official library https://github.com/googleapis/nodejs-storage

@malept
Copy link
Member

malept commented Jun 10, 2020

Are you volunteering to maintain this publisher? There are already a lot of publisher modules in this monorepo without a maintainer and I'd like to avoid more.

Alternatively, you can also maintain this in a separate repository.

@mahnunchik
Copy link
Contributor Author

@malept yep, why not. It is pretty simple and I'm interested in this publisher.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added you as a code owner of this module via GitHub's CODEOWNERS feature. You'll get pull request notifications any time files in the publisher module get changed.

Can you please add a pull request in https://github.com/MarshallOfSound/electron-forge-docs (which powers electronforge.io) for this module?

packages/publisher/gcs/src/PublisherGCS.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/PublisherGCS.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
packages/publisher/gcs/src/Config.ts Outdated Show resolved Hide resolved
@mahnunchik
Copy link
Contributor Author

Code fixed, documentation added ✅

@mahnunchik mahnunchik requested a review from malept June 11, 2020 14:17
@malept
Copy link
Member

malept commented Jun 11, 2020

This is blocked until I get access to merge PRs in the docs repo.

@mahnunchik
Copy link
Contributor Author

Ok, got it.

@MarshallOfSound could you please look into electron-forge/electron-forge-docs#9

@mahnunchik
Copy link
Contributor Author

@malept Hi, I think electron-forge/electron-forge-docs#9 can be merged.

@mahnunchik
Copy link
Contributor Author

@malept What should I do to have this PR merged?

@mahnunchik
Copy link
Contributor Author

@malept PR is rebased on latest master in new PR #2100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Cloud Storage publisher
2 participants