Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate or-ed dependency lists for dependencies with varying names #40

Closed
wants to merge 3 commits into from

Conversation

tobias-klein
Copy link

This pull request addresses electron-installer-redhat #130. Certain standard packages (namely libnotify, nss, libXtst, libuuid) have varying names depending on the exact RPM-based distribution (RedHat, Suse, ...). For these packages it is necessary to generate or-ed dependency lists, so that the resulting package works on different distributions.

@fcastilloec
Copy link
Collaborator

@tobias-klein Thanks for the PR. Just a few pointers, make sure that you run npm run lint and fix any issues, otherwise, the build will fail.
Also, this PR is not necessary. We only need to change electron-installer-redhat and submit a dependency array containing the or statement for the packages that have multiple names. As an example, see https://github.com/electron-userland/electron-installer-debian/blob/master/src/dependencies.js#L7 where | is the Debian equivalent of or.

The only problem I see with this is that we will break compatibility with any installer using rpm < 4.13.0 which shouldn't be a big deal since it's over 3 years old. Nonetheless, there are cases, like the default image in Travis uses an older version of rpm (Ubuntu Xenial) but there's a new image using Ubuntu 18.04. I primarily use Travis, so I'm not sure if other CIs will have this problem.

Unless @malept see something I'm not, we should probably close this PR.

@tobias-klein
Copy link
Author

Closing this since there is a possible solution without changes in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants