Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SuSE distributions? #130

Closed
tobias-klein opened this issue Jun 17, 2019 · 11 comments · Fixed by #131
Closed

Support for SuSE distributions? #130

tobias-klein opened this issue Jun 17, 2019 · 11 comments · Fixed by #131

Comments

@tobias-klein
Copy link
Contributor

I've been trying to install a rpm generated by electron-installer-redhat on OpenSuse 42.3. It didn't work, because some of the standard dependencies of the package were not found. Is SuSE supported in general or are there plans to support it?

@fcastilloec
Copy link
Collaborator

Could you be a more specific and show what are the dependencies failing to be installed? Also, are you using the latest release of this module (v2.0.0)?

@tobias-klein
Copy link
Contributor Author

tobias-klein commented Jun 18, 2019

When installing the RPM I get the following message from Yast:

#### YaST2 conflicts list - generated 2019-06-16 17:33:02 ####

nothing provides (kde-cli-tools or kde-runtime or trash-cli or glib2 or gvfs-client) needed by ezra-project-0.8.1-1.x86_64

This is with electron-installer-redhat 1.1.0. But I just tested once more and I'm getting the same error message still with version 2.0.0.

@malept
Copy link
Member

malept commented Jun 18, 2019

Well, that's confusing, because I did a cursory search and glib2 exists in openSUSE. What version of RPM do you have installed?

That being said, apparently kde-cli-tools is called kde-cli-tools5 in openSUSE.

@tobias-klein
Copy link
Contributor Author

On the system I'm installing the package it's RPM version 4.11.2 and on the system where I'm generating the package (a Docker image) it's 4.14.2.1.

@malept
Copy link
Member

malept commented Jun 18, 2019

I suspect the reason why it doesn't like the trash dependency line is because it requires RPM 4.13.0.

@malept
Copy link
Member

malept commented Jun 18, 2019

According to https://rpm.org/timeline.html, 4.13.0 was released almost 3 years ago.

@tobias-klein
Copy link
Contributor Author

Thanks for the additional hints. I'm not so familiar with different Suse releases and the package versions available for them. If a newer RPM is required then I'll give another newer Suse release a try. I've been using OpenSuse Leap 42.3 (released ~2 years ago). Imho, it's sometimes valuable to support older releases, because people don't always use the latest stuff. Thanks for your help, I appreciate it!

@fcastilloec
Copy link
Collaborator

@tobias-klein this tool supports old and new versions. All this fine tuning has to be done by the user, by using a newer rpm version when building you are excluding releases with older versions.

If you're not using shell.moveItemToTrash method from electron, it's better to build the installer on a Docker image with an older rpm version (< 4.13), this will make sure that it will work on all rpm versions.
If you do use that method, or can't build on an older system, you can add a dependency to rpm with options.requires on your config file, like this: [rpm >= 4.13]. That'll make sure your installer will work only on newer systems.

@tobias-klein
Copy link
Contributor Author

tobias-klein commented Aug 17, 2019

This issue is not closed from my perspective.

I just generated an RPM on OpenSuse Leap 15.1 (released in May 2019) and electron-installer-redhat (2.0.0) still seems to generate dependencies that are not compatible with that Suse distribution.

The following dependencies are not found when installing the generated package on OpenSuse Leap 15.1:

  • libXtst (package name on OpenSuse Leap: libXtst6)
  • libnotify (package name on OpenSuse Leap: libnotify4)
  • libuuid (package name on OpenSuse Leap: libuuid1)
  • nss (package name on OpenSuse Leap: (mozilla-nss)

I'd appreciate if you could re-open this ticket and provide a fix!

@malept
Copy link
Member

malept commented Aug 17, 2019

Feel free to provide a patch, as you seem to be more knowledgeable about OpenSuse. nss is Network Security Services.

@tobias-klein
Copy link
Contributor Author

I fixed this by making a change in electron-installer-common as well as electron-installer-redhat (see the two pull requests referenced above). The changes were tested successfully on OpenSuse Leap 15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants