Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

support preloading babel plugins without standardized name #73

Merged

Conversation

mnaamani
Copy link
Contributor

@mnaamani mnaamani commented May 9, 2017

This patch add support for electron-compiler to preload babel plugins that do not use a standardized name as the the npm module name, for example react-hot-loader

This indirectly helps to solve an issue when using electron-prebuilt-compile in an electron project and some npm dependencies are npm linked to a local "development package". When electron-compile can't preload a plugin defined in .compilerc babel-core ends up trying to locate all the plugins in the development package directory, and fails with an exception.

@mnaamani mnaamani changed the title Add support for preloading a plugin without standardized name support preloading babel plugins without standardized name May 11, 2017
@anaisbetts
Copy link
Contributor

anaisbetts commented May 13, 2017

I'll have a look at this in a bit, thanks for the PR

@mnaamani
Copy link
Contributor Author

I hope it will prove useful, and it's a pleasure to contribute to a great project.

Let me know if you need any clarification on any anything

@anaisbetts
Copy link
Contributor

anaisbetts commented May 22, 2017

Looks good! Sorry this took forever. I have one more PR to review then I'll put out a release

@anaisbetts anaisbetts merged commit 16dd016 into electron-userland:master May 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants