Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

react-hot-reload breaks app completely in monorepo #83

Open
walleXD opened this issue Nov 17, 2017 · 2 comments
Open

react-hot-reload breaks app completely in monorepo #83

walleXD opened this issue Nov 17, 2017 · 2 comments

Comments

@walleXD
Copy link

walleXD commented Nov 17, 2017

Hey all,

I am working on a project which is in a monorepo and the react components are in a separate package which are all connected by lerna. But if I use it with react-hot-loader it totally borks electron-compile & it complains:

Uncaught Error: Couldn't find preset "react-hot-loader" relative to directory "/Volumes/*/universal-react/packages/components/src"

Any idea how to fix this? It seems to be looking at the node_modules folder in the components package rather than the actual project's node_module folder

Thanks a bunch....

@walleXD walleXD changed the title react-hot-reload breaks app completely in monorepo react-hot-reload breaks app completely in monorepo Nov 17, 2017
@walleXD walleXD changed the title react-hot-reload breaks app completely in monorepo react-hot-reload breaks app completely in monorepo Nov 17, 2017
@mnaamani
Copy link
Contributor

@walleXD This fixes the issue #73
Although it has been merged but hasn't made it into a release yet.

The root cause is the react-hot-loader npm package really needs to be published as babel-plugin-react-hot-loader

I was thinking of publishing an npm package myself with this name. I'll try it out and report back. Ideally we can ask the maintainer of react-hot-loader to publish the package with that name.

@mnaamani
Copy link
Contributor

It would seem that adding the "next" branch version of react-hot-loader doesn't break. Can you confirm this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants