feat: allow custom makensis and logging #6024
Conversation
…ctly enable debugger logs for nsis installers (user specifies download url to nsis dev bundler)
| } | ||
| } | ||
| // noinspection SpellCheckingInspection | ||
| return getBinFromUrl("nsis", "3.0.4.2", "o+YZsXHp8LNihhuk7JsCDhdIgx0MKKK+1b3sGD+4zX5djZULe4/4QMcAsfQ+0r+a8FnwBt7BVBHkIkJHjKQ0sg==") |
There was a problem hiding this comment.
@develar I tried to update to 3.0.5.0 that is uploaded in electron-builder-binaries, but that throws CI errors:
Command line defined: "UNINSTALLER_OUT_FILE=C:\Users\RUNNER~1\AppData\Local\Temp\et-d8d6360ca6c99632f01b203b451e295c\t-oEMxqx\test-project-0\dist\__uninstaller-nsis-TestApp.exe"
Processing config: C:\Users\runneradmin\AppData\Local\electron-builder\Cache\nsis\nsis-3.0.5.0\nsisconf.nsh
Processing script file: "<stdin>" (ACP)
Error output:
Bad text encoding
Error in macro MUI_LANGUAGEEX on macroline 13
Error in macro MUI_LANGUAGE on macroline 4
Error in macro addLangs on macroline 5
Error in script "<stdin>" on line 112 -- aborting creation process
I couldn't easily identify why (MUI_LANGUAGEEX is no where in the codebase AFAICT) and 3.0.4.2 seems to have the log and max string length compiler flags enabled, so I'm just upgrading to that patch version here.
There was a problem hiding this comment.
@develar it happens here AFAICT
LoadLanguageFile "${LangDir}\${NLFID}.nlf"
https://github.com/electron-userland/electron-builder-binaries/blob/ec807af771a341b93d122734a9a1d6d2ae9bf90a/nsis/Contrib/Modern%20UI%202/Localization.nsh#L42
My best guess is that this file is no longer valid for newer versions of makensis:
https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-lang-fixes/SimpChinese.nlf
Alternatively, we could upgrade to makensis 3.0.6.1, but I'm struggling to figure out how to compile it for both windows & mac on my hackintosh.
🦋 Changeset detectedLatest commit: 85d89f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Enables providing your own
makensisbinary via URL and adds adebugLoggingconfig flag for enabling LogText macro within NSIS installers. Currently logs to the default directory (install path?)Contributions incorporate @shaluyadav13's PR #6024 (Thank you!)
Implements #5119