Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update / upgrade NSIS #42

Open
Simon-Laux opened this issue Jul 9, 2021 · 1 comment
Open

How to update / upgrade NSIS #42

Simon-Laux opened this issue Jul 9, 2021 · 1 comment

Comments

@Simon-Laux
Copy link

We have an issue where the installer is crashing sometimes (when the user directory contains spaces) before doing anything.
deltachat/deltachat-desktop#1269

I tried understanding the scripts but I currently don't have the time to find out how exactly everything works.

Can you describe what I need to do to make a build for or provide builds for:

  • the current nsis release (3.0.6.1 at the time of writing)
  • the current nsis master/nightly/next-release (3.0.7 at the time of writing)

I want to test if these new versions of NSIS can fix the issue.

@mmaietta
Copy link
Collaborator

mmaietta commented Jul 28, 2021

I tried to figure this one out as well but didn't manage to get far on Windows. There are these scripts that have hints as to what needs to be done
https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-prepare.sh
https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis.sh
https://github.com/electron-userland/electron-builder-binaries/blob/master/nsis-linux.sh

I could use an updated one for my PR adding debug logging to nsis installers electron-userland/electron-builder#6024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants