fix: macOS failing when there is no old icon

[djpereira]

This avoids throwing an ENOENT exception, if for any reason the old icon is not found to be deleted during the mac installer creation process.

Error: ENOENT: no such file or directory, unlink '/mypath/dist/canary/mac/Electron.app/Contents/Resources/myapp.icns'
    at Object.<anonymous> (/mypath/node_modules/electron-builder/src/packager/mac.ts:154:19)
From previous event:
    at Object.createApp (/mypath/node_modules/electron-builder/out/packager/mac.js:138:21)

[develar]

Do you use extendInfo?

[djpereira]

@develar, I am not using extendInfo.

[develar]

So, how error is possible if electron always has default icon?

[djpereira]

@develar, I am not sure, but I am running build more than once in different output directories and it fails the second time:

build --em.build.directories.output=dist/release
build --em.build.directories.output=dist/canary
build --em.build.directories.output=dist/dev

Also, I am using a custom electron build.

Now that I am digging into it, as far as I know, the default icon is "electron.icns", but the second time is trying to delete "myapp.icns". I am not sure why.

[develar]

Merged, but I will take a look why it is happened. Thanks.

[djpereira]

@develar, I think the problem here is that when we use electron-builder with the "electronDist" option, the custom dist gets copied over using "hard-links" instead of actually copying the content.

The problem with this, is that as the content of the electron dist "copy" gets modified (icons, name, etc.), the original electronDist source folder "mirrors" the changes.

This is not an issue for each use case, but you definitely get into trouble very often.
I think that ideally we want to make an actual copy of the files each time, not a hard link.