You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we use electron-builder with the "electronDist" option, the custom electron build gets copied over using "hard-links" instead of actually copying the content.
When you specify a custom electron build directory, dirPackager.unpack calls electron-builder-util.copyDir which uses hard-links by default.
The problem with this, is that as the content of the electron dist "copy" gets modified (icons, name, etc.) the original electronDist source folder "mirrors" the changes.
This is not an issue for each use case, but you definitely get into trouble very often, specially if you try to run electron-builder again.
I think that ideally we want to make an actual copy of the files each time, not a hard link.
When we use electron-builder with the "electronDist" option, the custom electron build gets copied over using "hard-links" instead of actually copying the content.
When you specify a custom electron build directory,
dirPackager.unpack
callselectron-builder-util.copyDir
which uses hard-links by default.The problem with this, is that as the content of the electron dist "copy" gets modified (icons, name, etc.) the original electronDist source folder "mirrors" the changes.
This is not an issue for each use case, but you definitely get into trouble very often, specially if you try to run electron-builder again.
I think that ideally we want to make an actual copy of the files each time, not a hard link.
This is why I had the problems mentioned in #1658
The text was updated successfully, but these errors were encountered: