Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the electronDist uses a hard-link instead of copying the custom electron build directory #1670

Closed
djpereira opened this issue Jun 14, 2017 · 1 comment · May be fixed by qcif/data-curator#563
Labels

Comments

@djpereira
Copy link
Contributor

  • Version: 18.6.2
  • Target: darwin

When we use electron-builder with the "electronDist" option, the custom electron build gets copied over using "hard-links" instead of actually copying the content.

When you specify a custom electron build directory, dirPackager.unpack calls electron-builder-util.copyDir which uses hard-links by default.

The problem with this, is that as the content of the electron dist "copy" gets modified (icons, name, etc.) the original electronDist source folder "mirrors" the changes.

This is not an issue for each use case, but you definitely get into trouble very often, specially if you try to run electron-builder again.

I think that ideally we want to make an actual copy of the files each time, not a hard link.

This is why I had the problems mentioned in #1658

@develar develar added the bug label Jun 14, 2017
develar added a commit to develar/electron-builder that referenced this issue Jun 14, 2017
@develar
Copy link
Member

develar commented Jun 14, 2017

Thanks for investigation, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants