-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question - Build NSIS for both 32 and 64 bits #1897
Comments
"win": {
"target": [
{
"target": "nsis",
"arch": [
"x64",
"ia32"
]
}
]
},
"linux": {
"target": [
{
"target": "AppImage",
"arch": [
"x64"
]
}
]
} and use
|
@cawa-93 Thank you! I've missed the "arch" options.. But the linux part is not necessary. By default only arch x64 is build. And what about setting by default arch x64 and ia32 when target is "nsis" for Windows build ? |
What do you have in mind? |
Currently, |
@develar I'm not sure that you have understand what I'm trying to say ^^
So, what do you think to change the current default build settings. And automatically build and include ia32 and x64 in nsis installer by default ? Now to do this, we should do:
But this would be more useful to only do that (I think all people who use nsis do that to support x64 and ia32 ?) :
|
I don't think that it is a good default. And ia32 must die. |
Yes, I think like you, but many users always run Windows with ia32.. :( So this will be more interesting for developper to support this by default. But this is only a "question/proposal".. This is not a problem for me to add this 2 more lines in package.json to config what I want. |
@popod I think you are wrong. Regardless of the choice of OS or target, a single approach to the default parameters should be maintained. It is not a good idea to build NSIS somehow differently |
@cawa-93 Okey, yes I understand. Thanks for reply ;) |
(In case anyone else gets here from google) It gives me the error "scripts": {
"dist": "electron-builder --ia32 --x64 -w"
} |
Same. Shame. |
It doesn't look like @cawa-93's configuration works anymore in v21.2.0, at least when using the programmatic API, what are we supposed to use now? |
Can u solve problem ? @fabiospampinato |
@Mhmetengineer I'm using builder.build ({
ia32: true,
x64: true,
win: {
target: [
'dir',
'nsis',
'zip'
]
}
}) |
↑ Error has occurred This worked fine |
if both architectures are built in, how can the user choose then? I'm on mac, trying to understand.
|
Yes, but still today there exist problems with 64 bit that do not exist with 32bit. So, @develar, yes, it should die, but the software should survive :) |
That's because It belongs inside the
I think you must've done the opposite of above. Try it inside the the |
It works: "scripts": {
"release-win": "electron-builder --win --publish always"
},
"build": {
"win": {
"artifactName": "${productName} Setup ${version} ${arch}.${ext}",
"target": [
{
"target": "nsis",
"arch": [
"x64",
"ia32"
]
}
]
}
} |
For win:
target:
target: nsis
arch:
- x64
- ia32
executableName: your-app-name
nsis:
artifactName: ${name}-${version}-${arch}.${ext}
shortcutName: ${productName}
uninstallDisplayName: ${productName}
createDesktopShortcut: always |
With electron-builder v19.19.1, when I build for windows with defaults params
build -w
, I get a nsis installer who only works for 64 bits. Is it correct ?In fact, I expected that by default, the nsis contain both 32 and 64 bits versions. What do you think to do this behaviour by default ?
And second, is there any way to define the build target arch for Windows only in the package.json ? Because, now I use
build -wml --x64 --ia32
and it build 32 bits versions for linux too and I do not want that..Thanks
The text was updated successfully, but these errors were encountered: